Behind the scenes tidy up

[cjrace]

Pull request overview

Doing a general tidy up of the template ahead of creating a new repo, aiming to resolve some known issues.

Considered updating to bslib though deciding that should be a separate PR as this was already big enough to review. Raised a number of issues in the Accessibility UI refresh milestone to cover those.

Pull request checklist

Please check if your PR fulfils the following:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Tests have been run locally and are passing (shinytest2::test_app())
• Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

Details of changes

Lots, sorry! Happy to have a call with people if easier.

Automated tests

• Fix Add example testthat test #10 by adding example testthat tests
• Add example server integration tests
• Fix Update the UI tests to not care about the details of the data #76 by showing different approaches to UI tests

CI

• Fix Update GHA scripts to use Ubuntu latest #73 by switching to Ubuntu VMs for the action runs
• Update versions of actions to the latests
• Removed tidyCode action as not needed as we have the pre-commit hook

Code tidy up

• Ran lintr::lintr_dir() locally and resolved all issues so there's a clean starting point
• Updated references from stats development to EES team
• Added README.html to .gitignore to avoid anyone accidentally committing a html version and it going out of date
• Moved code around to reduce number of scripts we have, and to make a folder for separate UI panels to live in to keep the individual scripts shorter and easier to manage
• Updated some of our comments around code, including the CSS file
• Removed the custom CSS loading screen, could be convinced to bring back if we really want it
• Updated the README to be focussed around a template that others can make use of and easily update

ggplot element_line()

• The size argument is now depreciated so I've followed the warning message to update it
  

Styling

• Updated text CSS to use Arial consistently as our text was anything but consistent before
• Updated accessibility statement to use p() tags instead of br() which was causing unusual spacing

Anything else

• Simplified the code behind the value boxes to allow for exporting reactive values (though also I think makes it easier to read), and dropped some of the example value boxes as they were a bit overwhelming on the first page. This also gives the benefit of making it visually clear we've made an update

• One of the reasons for showing the value exporting approach to UI tests is that I think we should be encouraging that moving forwards. shinytest2's documentation on suggested approaches certainly does:

It cannot be recommended enough to use shiny::exportTestValues() to test your Shiny app’s reactive values.

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[cjrace]

Update shiny template ahead of starting FE dashboard

[rmbielby]

Might review this in chunks, here's some initial thoughts from a first sweep...

[rmbielby]

A few minor suggestions