Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Govuk dropdown styling #93

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Govuk dropdown styling #93

merged 2 commits into from
Oct 16, 2024

Conversation

chfoster
Copy link
Contributor

@chfoster chfoster commented Sep 18, 2024

Pull request overview

Update single-selection dropdowns to use shinygovstyle::select_input() for styling and accessibility purposes, close #80

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Current dropdowns use selectizeInput() as below
image

What is the new behaviour?

New dropdowns use shinyGovstyle::select_Input():

image

Anything else

NOTE there is still a remaining selectizeInput() that currently allows multiple selections, as there is no functionality for this yet in shinyGovstyle. We might want to create a new issue for this.

Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a quick test locally and all seems to work as expected.

Assuming we'll probably remove the extra CSS when we update the template to use bslib and change up the well panel where the dropdowns live but can worry about that in a later PR.

@chfoster chfoster merged commit c4e971b into main Oct 16, 2024
3 checks passed
@cjrace cjrace deleted the govuk_dropdown_styling branch October 16, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change dropdowns to use gov.uk styling
2 participants