Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend data file suffix check in commit hooks #94

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

rmbielby
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (shinytest2::test_app())
  • Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

The commit hooks don't check for a range of possible data file types:

  • parquet
  • ods
  • zip
  • gz
  • rds
  • rda

What is the new behaviour?

The commit hooks now check for all the above file types (in addition to csv, xlsx, etc) and refuses to commit if they're not explictly logged in the data log file.

Anything else

Resolves #92

@rmbielby rmbielby self-assigned this Oct 16, 2024
@rmbielby rmbielby linked an issue Oct 16, 2024 that may be closed by this pull request
Copy link
Contributor

@cjrace cjrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with a couple of examples locally and works as expected

@rmbielby rmbielby merged commit 0923377 into main Oct 16, 2024
3 checks passed
@cjrace cjrace deleted the feature/extend-data-file-suffix-check branch October 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zip file types to existing commit hook for unpublished data
2 participants