Skip to content

Commit

Permalink
update css file name, attach dependency and update contributing guide…
Browse files Browse the repository at this point in the history
…lines for css changes
  • Loading branch information
sarahmwong committed Dec 19, 2024
1 parent 6802a1f commit 20c6de5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,13 @@ Currently we take [static precompiled exports of the GOV.UK Frontend files](http

2. Download and unzip the ZIP folder, copying the assets (including fonts and images) into the `inst/www/` folder

3. Apply any changes from `css_changes.md` manually, to preserve previous edits
3. Update the CSS file name in `attachDependency.R` script

4. Test all the code functions as expected using `devtools::check()`
4. Apply any changes from `css_changes.md` manually, to preserve previous edits

5. Manually test the examples using `shinyGovstyle::run_example()`, ensuring the styling is as expected
5. Test all the code functions as expected using `devtools::check()`

6. Manually test the examples using `shinyGovstyle::run_example()`, ensuring the styling is as expected

If unsure on the styling and expected appearance, use the [GOV.UK Design System site](https://design-system.service.gov.uk/) to explore the components in more detail and official guidance for their use.

Expand Down
2 changes: 1 addition & 1 deletion R/attachDependency.R
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ attachDependency <- function(tag, widget = NULL) {
dep <- htmltools::htmlDependency(
name = "stylecss", version = version,
src = c(href="shinyGovstyle/css"),
stylesheet = "govuk-frontend-norem.css"
stylesheet = "govuk-frontend-5.7.1.min.css"
)

if (!is.null(widget)) {
Expand Down
File renamed without changes.

0 comments on commit 20c6de5

Please sign in to comment.