105 update to latest govuk frontend version

[sarahmwong]

Overview of changes

Update to 5.7.1 frontend - adding @cjrace as a reviewer as you've had experience updating this before too!

Everything looks ok apart from value boxes - tested this in master and still looks odd! I've raised #116 for Andy to revisit as this looks like a separate issue.

Removed some old manual changes from the css_changes.md file as no longer relevant

PR Checklist

• I have updated the documentation (if needed)
• I have added or updated tests for these changes (if applicable)
• I have tested these changes locally using devtools::check()

Reviewer instructions

Run devtools::load_all

Run run_example()

Check that all css changes look ok and functionality still works

[cjrace]

Not fully tested everything, but leaving the comments I have for now so they're not lost (as I'm not around tomorrow)

Spotted an issue with accordions (though not cross checked against main yet to see if it's pre-existing)

• Only the 'show' is clickable, if you click on the title of the accordion it doesn't open, though for GDS component it seems like clicking anywhere around the accordion title should also open it? https://design-system.service.gov.uk/components/accordion/

[cjrace]

Have finished my review now, there's only one other odd thing I've noticed (may or may not be related to the fonts comment)

Select input (dropdown) now cuts the bottom of text off

Before

After

[sarahmwong]

Thanks for your comments @cjrace! I think these have been addressed now - think the font fix fixes the selection box (looks like this to me):

Accordions issue is pre-existing in master good spot! I've raised #123 for a fix - can ask Jeni to take a look unless you wanted to have a go with faffing with the JS! 😄

[cjrace]

Nice! All looks good, and thanks for updating the css_changes.md to match too