Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length counting of zero sized values #460

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Fix length counting of zero sized values #460

merged 7 commits into from
Aug 30, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

No description provided.

@github-actions
Copy link

Benchmark for 5f9c179

Click to view benchmark
Test Base PR %
Blob/&str 210.8±119.26µs 211.0±119.56µs +0.09%
Blob/ByteBuf 142.0±48.01µs 134.2±49.00µs -5.49%
Blob/Bytes 106.7±46.08µs 106.7±44.71µs 0.00%
Blob/String 246.4±130.51µs 245.6±130.36µs -0.32%
Collections/vec (text, nat) 63.1±0.70ms 63.2±0.72ms +0.16%
Collections/vec int 30.2±0.09ms 31.1±0.08ms +2.98%
Collections/vec int64 17.4±0.21ms 17.8±0.14ms +2.30%
Collections/vec nat8 13.2±0.07ms 13.1±0.08ms -0.76%
option list/1024 1328.9±1.36µs 1349.4±5.53µs +1.54%
profiles/1024 2.6±0.01ms 2.5±0.02ms -3.85%
variant list/1024 1120.0±1.65µs 1134.2±4.54µs +1.27%

@github-actions
Copy link

Benchmark for 1072bd7

Click to view benchmark
Test Base PR %
Blob/&str 223.3±57.08µs 248.9±70.84µs +11.46%
Blob/ByteBuf 158.6±44.94µs 161.4±45.24µs +1.77%
Blob/Bytes 107.9±30.36µs 110.4±32.22µs +2.32%
Blob/String 235.1±68.90µs 251.0±67.22µs +6.76%
Collections/vec (text, nat) 70.2±1.04ms 70.9±1.40ms +1.00%
Collections/vec int 32.6±0.06ms 33.3±0.11ms +2.15%
Collections/vec int64 19.4±0.25ms 19.7±0.14ms +1.55%
Collections/vec nat8 14.2±0.03ms 13.9±0.03ms -2.11%
option list/1024 1363.0±15.23µs 1379.9±2.54µs +1.24%
profiles/1024 2.6±0.00ms 2.6±0.00ms 0.00%
variant list/1024 1133.0±1.86µs 1137.1±2.19µs +0.36%

@github-actions
Copy link

Benchmark for c7eee30

Click to view benchmark
Test Base PR %
Blob/&str 246.9±67.58µs 222.8±56.57µs -9.76%
Blob/ByteBuf 157.7±44.35µs 157.0±44.03µs -0.44%
Blob/Bytes 109.7±30.88µs 107.2±30.42µs -2.28%
Blob/String 245.2±68.49µs 241.9±66.23µs -1.35%
Collections/vec (text, nat) 70.4±1.23ms 70.7±1.22ms +0.43%
Collections/vec int 32.6±0.07ms 32.9±0.06ms +0.92%
Collections/vec int64 19.4±0.37ms 19.5±0.28ms +0.52%
Collections/vec nat8 13.9±0.02ms 13.9±0.02ms 0.00%
option list/1024 1386.3±4.44µs 1376.8±2.50µs -0.69%
profiles/1024 2.7±0.01ms 2.7±0.01ms 0.00%
variant list/1024 1140.5±12.26µs 1129.9±2.00µs -0.93%

@github-actions
Copy link

Benchmark for 2e008f2

Click to view benchmark
Test Base PR %
Blob/&str 242.8±68.36µs 213.4±59.54µs -12.11%
Blob/ByteBuf 153.7±45.57µs 156.1±45.00µs +1.56%
Blob/Bytes 100.9±32.09µs 106.5±30.78µs +5.55%
Blob/String 239.8±68.58µs 233.5±67.37µs -2.63%
Collections/vec (text, nat) 69.6±0.79ms 71.2±1.12ms +2.30%
Collections/vec int 32.4±0.07ms 32.8±0.08ms +1.23%
Collections/vec int64 19.2±0.22ms 18.8±0.40ms -2.08%
Collections/vec nat8 13.8±0.02ms 13.7±0.03ms -0.72%
option list/1024 1383.1±3.08µs 1390.9±2.59µs +0.56%
profiles/1024 2.7±0.01ms 2.7±0.00ms 0.00%
variant list/1024 1136.7±2.35µs 1151.1±1.73µs +1.27%

@github-actions
Copy link

Benchmark for fa3ccdb

Click to view benchmark
Test Base PR %
Blob/&str 242.0±69.83µs 214.1±58.84µs -11.53%
Blob/ByteBuf 154.5±47.10µs 163.0±43.38µs +5.50%
Blob/Bytes 103.5±31.34µs 110.6±32.04µs +6.86%
Blob/String 238.9±68.37µs 230.4±68.15µs -3.56%
Collections/vec (text, nat) 69.9±1.18ms 70.2±0.85ms +0.43%
Collections/vec int 31.9±0.09ms 33.5±0.54ms +5.02%
Collections/vec int64 18.7±0.22ms 19.6±0.27ms +4.81%
Collections/vec nat8 13.8±0.02ms 14.1±0.13ms +2.17%
option list/1024 1377.3±6.73µs 1383.1±1.41µs +0.42%
profiles/1024 2.7±0.02ms 2.6±0.01ms -3.70%
variant list/1024 1133.9±1.94µs 1131.1±1.80µs -0.25%

@github-actions
Copy link

Benchmark for 589a487

Click to view benchmark
Test Base PR %
Blob/&str 231.4±107.78µs 208.0±59.50µs -10.11%
Blob/ByteBuf 145.2±47.45µs 145.6±47.26µs +0.28%
Blob/Bytes 102.4±43.25µs 103.6±43.56µs +1.17%
Blob/String 268.6±121.72µs 260.4±122.95µs -3.05%
Collections/vec (text, nat) 65.5±0.83ms 65.0±0.48ms -0.76%
Collections/vec int 31.4±0.04ms 32.0±0.04ms +1.91%
Collections/vec int64 17.7±0.18ms 17.3±0.19ms -2.26%
Collections/vec nat8 13.8±0.01ms 14.2±0.05ms +2.90%
option list/1024 1374.0±1.12µs 1378.0±3.00µs +0.29%
profiles/1024 2.7±0.00ms 2.7±0.00ms 0.00%
variant list/1024 1133.3±1.46µs 1133.1±1.89µs -0.02%

@chenyan-dfinity chenyan-dfinity merged commit 7273592 into master Aug 30, 2023
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the fix-zsv branch August 30, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants