Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size hints in order to optimize allocation during deserialization #570

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Add size hints in order to optimize allocation during deserialization #570

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b91652
Add size hints in order to optimize allocation during deserialization
frankdavid Aug 26, 2024
e10f947
Format
frankdavid Aug 26, 2024
84ab455
Format
frankdavid Aug 26, 2024
73e60aa
Merge branch 'master' into frankdavid/opt
chenyan-dfinity Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions rust/candid/src/de.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,6 +1128,14 @@ impl<'de, 'a> de::SeqAccess<'de> for Compound<'a, 'de> {
_ => Err(Error::subtype("expect vector or tuple")),
}
}

fn size_hint(&self) -> Option<usize> {
match &self.style {
Style::Vector { len, .. } => Some(*len),
Style::Struct { expect, wire, .. } => Some(expect.len().min(wire.len())),
_ => None,
}
}
}

impl<'de, 'a> de::MapAccess<'de> for Compound<'a, 'de> {
Expand Down Expand Up @@ -1221,6 +1229,14 @@ impl<'de, 'a> de::MapAccess<'de> for Compound<'a, 'de> {
}
}
}

fn size_hint(&self) -> Option<usize> {
match &self.style {
Style::Map { len, .. } => Some(*len),
Style::Struct { expect, wire, .. } => Some(expect.len().min(wire.len())),
_ => None,
}
}
}

impl<'de, 'a> de::EnumAccess<'de> for Compound<'a, 'de> {
Expand Down
Loading