Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer named parameter layout from dict-type initial_state #463

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zachjweiner
Copy link

Here's a first attempt (tests, etc., will have to come another day). Some notes:

  • This remains backwards-compatible with parameter_names, but I'm happy to axe it entirely if you aren't committed to parameter_names as supported without deprecation.
  • Setting state (self.param_slice_shape) after __init__ isn't ideal, but I'm not sure how else to get that info to compute_log_prob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant