Allow metadata editing #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfoxg
requested changes
Jan 4, 2024
There was a problem hiding this comment.
@toonalbers thanks a lot for that PR! I just noticed two small things, could you have a look at it? After that i will create a new release with your changes. Thanks🎉
Comment on lines
-139
to
+171
| adminMedataData: {}, | ||
| adminMetadata: {}, |
There was a problem hiding this comment.
I just checked the code, i wasnt able to create a new identity with metadata - the values just get dropped. I think we have to include the code from the lines 163 and 164.
There was a problem hiding this comment.
Interesting, I am not able to reproduce that - on our Kratos v1.0.0 installation, creating and updating identities with public or admin metadata works well. Could you perhaps try it with this schema? https://gist.github.com/toonalbers/d4b4fcf2472404066de47061ca37cc3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for creating this very useful tool. In our case we also needed to be able to edit metadata fields:
This PR:
The editor will show fields to edit the public and admin metadata if they have been defined in the Identity schema.