Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Box for Identity Filtering #193

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

dhia-gharsallaoui
Copy link
Contributor

Overview

This pull request introduces a new search box functionality to the Identities page, allowing users to filter identities based on their input. Additionally, it proposes the introduction of a code formatter to the project to maintain consistent code style and reduce diffs caused by style discrepancies.

Key Changes

  1. Search Box Implementation:

    • A search box has been added to the Identities page, positioned on the right side of the toolbar.
    • Users can now filter identities based on ID, State, Schema, or Verifiable Addresses.
    • The search functionality is case-insensitive and dynamically filters the displayed identities as the user types.
    • The filtering is retained even after the data is refreshed, ensuring a consistent user experience.
  2. Toolbar Layout Update:

    • The toolbar has been updated to use CSS flexbox for better alignment and distribution of elements. This change ensures that the search box is aligned to the left, while the command bar items are aligned to the right.

Proposal to Add Code Formatter:

  • To maintain consistent code style across the project and avoid unnecessary diffs caused by style discrepancies, I propose integrating a code formatter such as Prettier or ESLint.
  • This would help in automatically enforcing coding standards and formatting rules, making the codebase cleaner and easier to maintain.
  • Including a formatter would also streamline the review process by focusing on logical changes rather than stylistic ones.

Testing & Validation

  • The new search functionality has been tested to ensure it correctly filters identities based on user input and maintains the filter state after data refresh.

Next Steps

  • Formatter Integration: If the proposal for a code formatter is accepted, I suggest adding a configuration file (.prettierrc or .eslintrc) to the project and updating the contributing guidelines to include formatting checks before commits.

Closing Notes

This PR aims to enhance the user experience on the Identities page and improve code quality through better organization and formatting practices. Your feedback on both the search functionality and the formatter proposal is highly appreciated.

Screenshots

image
image

Fix some typo
format file
Copy link
Owner

@dfoxg dfoxg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thank you very much for that contribution! I´m gonna check the formatter, thanks for that hint!

@dfoxg dfoxg merged commit 70f1bd9 into dfoxg:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants