Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new API #37

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dakur
Copy link

@dakur dakur commented Sep 19, 2023

Closes #36

I have:

  • decoupled API client from public facade
  • decoupled caching from API client
  • started implementation of v2 API
  • implemented an auto-switch to new API on 1st of October

However I've spent already quite a long time with it so now I put it here so that someone can finish the work. There are TODOs in AresV2 class - basically 3 of 4 methods have to be rewritten and the already rewritten method has some BC issues which I'm not able to solve on my own. Maybe @dfridrich can look into that BC issues.

Resources:

@dakur
Copy link
Author

dakur commented Sep 19, 2023

cc @patrikvalentaa @petrparolek

@dakur dakur marked this pull request as draft September 19, 2023 05:51
@dakur dakur changed the title WIP: Implement new API Implement new API Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ARES from 30th of September 2023!
1 participant