-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix: UV location must use district globalId #13
Conversation
I also made some changes to the tests because they were not working for me. From what I gathered, the fixtures folder path was wrong, but feel free to change it in case the issue was specific with my setup. There was also a test dependency missed, which I added to the requirements file. |
Acho que podemos falar em português :) UV index nunca cheguei a terminar... estava mesmo era uma copia do risco de incendio. Obrigado :) Agora o path das fixtures é que me está a fazer espécie... partir de onde executas os testes ? |
Tens toda a razão.. Estava a executar diretamente do ficheiro, por isso é que não funcionava. |
Os distritos não mudam, melhor fazer o pedido no |
Bom ponto. Amanhã trato disso. Obrigado
…On Wed, 13 Sept 2023, 00:56 Diogo Gomes, ***@***.***> wrote:
Os distritos não mudam, melhor fazer o pedido no get() e guardar como
cache.
—
Reply to this email directly, view it on GitHub
<#13 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQZFMD2E7CQIDTNYARZ2QTX2DZCRANCNFSM6AAAAAA4VRYNAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Obrigado! |
Ora essa, o prazer é meu! Já agora, consegues dar bump na depedencia no Home Assistant que eu depois abro logo o PR para adicionar o UV Index como sensor? Visto seres o autor da integração devem aceitar o teu PR mais rápido! |
Abre tu o bump com o sensor extra, e eu posso fazer o review ;) |
The current uv index retrieval implementation does not work properly due to wrong global id being used. This will result in an unknown result most of the times. To fix this, the closest district id must be used instead of the current location.
After this is fixed, I already have a PR ready to go on Home Assistant to include the UV Index as a sensor.