Added docker build env for fedora25 #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CentOS binary would also work, but can you update to Fedora 26? |
gbraad
reviewed
Aug 18, 2017
| @@ -0,0 +1,18 @@ | |||
| FROM fedora:25 | |||
There was a problem hiding this comment.
Sorry for the delay. Yes I will change it for the fedora 26. Sorry for the late reply.
gbraad
approved these changes
Aug 18, 2017
|
Actually, I have tested the CentOS and my build. They both work the same. But this is a more obvious approach to broader public :). Comments from Reviewable |
|
Is this PR still relevant? Or can we close it? |
|
If the project gets transfered to the docker-machines organization we can
have a new look at this =>
#67
|
|
I am closing this PR. It is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for Fedora25, since I needed it.
If it fits Your plan, would You kindly merge it? I will be happy to maintain further versions.
Best regards,
Petr
This change is