[Network-score] scoring skeletal: 8 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikay <[email protected]>
Signed-off-by: Kartikay <[email protected]>
vatsa287
requested changes
Aug 27, 2024
packages/network-score/scoring.go
Outdated
| "regexp" | ||
|
|
||
| "github.com/kartikaysaxena/cord.go/packages/did" | ||
| identifier "github.com/kartikaysaxena/cord.go/packages/identifier/src" |
There was a problem hiding this comment.
Why are these being imported under karthikaysaxena.?
If you require some changes to be made to the upstream and then be used.
Please ask, I would fork upstream under dhiway, where you would make changes required.
There was a problem hiding this comment.
Actually I made the sdk and tried to publish it and import it remotely to check if it working, in Go, the library names are based on the Github URIs that we publish the code into, changing this to dhiway/cord.go would be simple, would do that.
kartikaysaxena
changed the title
Signed-off-by: Kartikay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.