added docstring to __entrofy #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhuppenkothen Thanks for the docstring. Looks good to me. |
bmcfee
reviewed
Sep 18, 2018
| k : int | ||
| The number of participants in the output set. This is the number of candidates to be selected and returned | ||
| by this function | ||
|
|
There was a problem hiding this comment.
The rng parameter should go here
bmcfee
requested changes
Sep 18, 2018
|
It only took, uh, over a year, but here you go. Parameter added. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gave the
__entrofyfunction a docstring, as suggested by @rgaiacs in issue #47.This change is