Included prefixes in construct_mapper function, added tests, updated notebook #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the prefixes I've been using in practice weren't included in the
construct_mapper
function, so I included them there. I also updated the notebook, which didn't mention prefixes at all.As a side note, do we really not have tests for
entrofy.core
? Or are they somewhere else? That code probably should have tests ...I added a few specifically for the
construct_mapper
function for now.This change is