Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant comments #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhpvorderman
Copy link

@rhpvorderman rhpvorderman commented Nov 6, 2021

This makes a bit of space for other PRs such as #272.

This PR:

  • Changed some of the function names to be more descriptive.
  • Changed some of the log messages to be more descriptive.
  • Inlined a comment.

Thusly 11 lines of comments were made redundant and were removed. Also I think the more descriptive names help with readability as well.

Thank you for this great project! The README here is miles ahead of any explanation on the official Let's Encrypt and Certbot websites. The ACME protocol is not that difficult to understand, but this code and your README gives the only comprehensive and easy to understand account of how it functions. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant