Fix: Parsing of escaped comma in querystring

dicebear · Oct 13, 2023 · 1e8294a · 1e8294a
1 parent f1bec71
commit 1e8294a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/utils/parseQueryString.ts b/src/utils/parseQueryString.ts
@@ -2,7 +2,9 @@ import qs from 'qs';
 
 export function parseQueryString(str: string): Record<string, unknown> {
   const result = Object.create(null);
-  const parsed = qs.parse(str, {
+  // @see https://github.com/dicebear/dicebear/issues/382
+  const preparedStr = str.replaceAll('%2C', ',');
+  const parsed = qs.parse(preparedStr, {
     comma: true,
     plainObjects: true,
     depth: 1,

diff --git a/tests/http.test.js b/tests/http.test.js
@@ -25,6 +25,22 @@ for (let version of [5, 6, 7]) {
       path: `/${version}.x/initials/svg/size=a`,
       status: 400,
     },
+    {
+      path: `/${version}.x/initials/svg?backgroundColor=000000,ffffff`,
+      status: 200,
+    },
+    {
+      path: `/${version}.x/initials/svg/backgroundColor=000000,ffffff`,
+      status: 200,
+    },
+    {
+      path: `/${version}.x/initials/svg?backgroundColor=000000%2Cffffff`,
+      status: 200,
+    },
+    {
+      path: `/${version}.x/initials/svg/backgroundColor=000000%2Cffffff`,
+      status: 200,
+    },
     {
       path: `/${version}.x/initials/schema.json`,
       status: 200,