Merge pull request #1515 from didi/feat-bind-this

优化 MemberExpression 逻辑
didi · Jul 16, 2024 · e749c3f · e749c3f
2 parents 45c7fd9 + 68490c8
commit e749c3f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/packages/webpack-plugin/lib/template-compiler/bind-this.js b/packages/webpack-plugin/lib/template-compiler/bind-this.js
@@ -127,12 +127,8 @@ function checkDelAndGetPath (path) {
     }
 
     if (t.isMemberExpression(parent) && parent.computed) {
-      if (key === 'property') {
-        replace = true
-      } else {
-        canDel = false
-        break
-      }
+      canDel = false
+      break
     }
 
     if (t.isLogicalExpression(parent)) { // case: a || ((b || c) && d)

diff --git a/packages/webpack-plugin/test/platform/common/bind-this.spec.js b/packages/webpack-plugin/test/platform/common/bind-this.spec.js
@@ -123,10 +123,8 @@ global.currentInject.render = function (_i, _c, _r, _sc) {
 global.currentInject.render = function (_i, _c, _r, _sc) {
   if (_c("a.b")) {}
 
-  _sc("c");
-
-  _sc("a")[""];
-  _c("a.b")[""];
+  _sc("a")[_sc("c")];
+  _c("a.b")[_c("c.d")];
 
   _sc("e");
 };`
@@ -379,8 +377,7 @@ global.currentInject.render = function (_i, _c, _r, _sc) {
 global.currentInject.render = function (_i, _c, _r, _sc) {
   this.name;
 
-  this.name2;
-  this.name3[""];
+  this.name3[this.name2];
 
   this.name4 && this.name4.length;
   this.name4['length'];