fix: rn tap event #1625
Open
fix: rn tap event #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2024 16:39
hiyuki
reviewed
Sep 14, 2024
| @@ -166,6 +181,7 @@ const useInnerProps = ( | |||
| const capturePressEvent = ['capture-catchlongpress', 'capture-bindlongpress'] | |||
| ref.current.startTimer[type] = null | |||
| ref.current.needPress[type] = true | |||
| hasEmittedTouchmove = false | |||
There was a problem hiding this comment.
感觉没必要记录这个，touchend直接加上检测就行了
There was a problem hiding this comment.
以及即使要加这个也应该和needPress对齐，不应该一个记录在实例上一个记录在全局
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.