Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #2

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Fix typos #2

merged 3 commits into from
Jan 19, 2024

Conversation

njoguamos
Copy link
Contributor

@njoguamos njoguamos commented Jan 19, 2024 •
edited
Loading

  • In the installation instruction, the code copied was npm install sonner instead of npm install qwik-sonner.
  • In the hero component, the word 'React' was replaced by Qwik
  • In the Usage file, the import should be from qwik-sonner not sonner

@njoguamos
Add the correct copy code
d68bd64 
In the installation instruction, the code copied was `npm install sonner` instead of `npm install qwik-sonner`.
@njoguamos
Rename React to Qwik
fb322de
@njoguamos
Update to the correct import
a358eee
@njoguamos njoguamos changed the title Add the correct copy code Fix typos Jan 19, 2024
@diecodev diecodev merged commit f9d280d into diecodev:main Jan 19, 2024
1 check passed
@diecodev
Copy link
Owner

thanks for this PR, I just realized that I need to create the CONTRIBUTING.md to explain how the commits should be done, mb.

@njoguamos
Copy link
Contributor Author

Agreed. A CONTRIBUTING.md would help future contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diecodev diecodev diecodev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njoguamos @diecodev