Add comment on relevance of order for Queryable #3376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @weiznich over on Matrix
Ten0
approved these changes
Oct 19, 2022
|
This looks like an sqlite-specialized example. Do we have equivalents for the other backends? If that's the case we probably want to add this comment here as well no? |
|
Thanks for opening this PR 👍 The relevant examples for are here for mysql and here for postgresql. I agree that we should add the comment there as well. The CI currently fails due to a change in clap. That's unrelated to this PR. I pushed a fix for that here, but that's not merged to master yet. |
weiznich
reviewed
Oct 19, 2022
| @@ -1,5 +1,8 @@ | |||
| use diesel::prelude::*; | |||
|
|
|||
| // Order matters here! | |||
| // Queryable assumes that the order of field on the struct matches the columns in the corresponding table. | |||
| // See https://docs.diesel.rs/diesel/deserialize/trait.Queryable.html#derivingfor details | |||
There was a problem hiding this comment.
We should point to the current documentation, instead to the old diesel 1.4 documentation here.
Suggested change
| // See https://docs.diesel.rs/diesel/deserialize/trait.Queryable.html#derivingfor details | |
| // See https://docs.diesel.rs/master/diesel/deserialize/derive.Queryable.html for details |
Jaffa-Cakes
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @weiznich over on Matrix