Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Codecov CI job #8339

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

tautschnig
Copy link
Collaborator

Please review commit-by-commit.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added the CI label Jun 18, 2024
@tautschnig tautschnig self-assigned this Jun 18, 2024
@tautschnig tautschnig force-pushed the codecov-multiple-platforms branch 4 times, most recently from e3123bb to 8e2c440 Compare June 18, 2024 09:24
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (cbc5079) to head (62cf283).

Current head 62cf283 differs from pull request most recent head 9fa738a

Please upload reports for the commit 9fa738a to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8339      +/-   ##
===========================================
- Coverage    78.35%   78.10%   -0.26%     
===========================================
  Files         1726     1726              
  Lines       188405   189040     +635     
  Branches     18446    18352      -94     
===========================================
+ Hits        147634   147645      +11     
- Misses       40771    41395     +624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the codecov-multiple-platforms branch 15 times, most recently from b8ab83e to 62cf283 Compare June 20, 2024 09:03
pull-request-checks.yaml has become too large to manage. Also prepares
improvements to the coverage job.
@tautschnig tautschnig assigned peterschrammel and TGWDB and unassigned tautschnig Jun 21, 2024
@tautschnig tautschnig marked this pull request as ready for review June 21, 2024 12:18
@tautschnig tautschnig requested review from peterschrammel and a team as code owners June 21, 2024 12:18
We changed the number of vCPUs for most scenarios in 55e5bdf, but
failed to also propagate this to coverage-recording test execution.
@tautschnig tautschnig merged commit 324565d into diffblue:develop Jul 9, 2024
36 of 38 checks passed
@tautschnig tautschnig deleted the codecov-multiple-platforms branch July 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants