Solver factory: make_satcheck_prop does not require dynamic_cast

[tautschnig]

We can determine at compile time whether a particular solver has harness support for any given call site.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (d635850) to head (5e08a81).

Files	Patch %	Lines
src/goto-checker/solver_factory.cpp	46.15%	7 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8410      +/-   ##
===========================================
- Coverage    78.04%   78.03%   -0.02%     
===========================================
  Files         1726     1726              
  Lines       189394   189424      +30     
  Branches     18263    18459     +196     
===========================================
- Hits        147810   147809       -1     
- Misses       41584    41615      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.