[JARS-144] Document that dont have rdf:type relation are ingested #146
Conversation
cookies/accession/zotero.py
Outdated
| raise StopIteration() | ||
| self.current_entries = self._get_resources_nodes(self.current_class) | ||
| next_entry = self.current_entries.next() | ||
| for i in self.graph.objects(subject=next_entry): |
There was a problem hiding this comment.
i is a pretty bad variable name
There was a problem hiding this comment.
why don't you provide the predicate you're looking for here? there is no reason to iterate over all triples. in addition, if any of the other triples have an object 'attachment', the entry will be skipped although it might be a real one.
There was a problem hiding this comment.
also, just assume there is either no itemtype or one. if there are more than one, this would be an error anyways and the other ones can be disregarded.
cookies/accession/zotero.py
Outdated
| self.current_entries = self._get_resources_nodes(self.current_class) | ||
| next_entry = self.current_entries.next() | ||
| for i in self.graph.objects(subject=next_entry): | ||
| if str(i) == 'attachment': |
|
Made the following changes :-
|
| raise StopIteration() | ||
| self.current_entries = self._get_resources_nodes(self.current_class) | ||
| next_entry = self.current_entries.next() | ||
| if str(next(self.graph.objects(subject=next_entry, predicate=ZOTERO.itemType))) == \ |
There was a problem hiding this comment.
what if 'self.graph.objects(subject=next_entry, predicate=ZOTERO.itemType)' is None?
| next_entry = self.current_entries.next() | ||
| if str(next(self.graph.objects(subject=next_entry, predicate=ZOTERO.itemType))) == \ | ||
| settings.ATTACHMENT_ITEMTYPE: | ||
| next_entry = None |
There was a problem hiding this comment.
len still returning wrong length
No description provided.