[JARS-146] Resource should be accessible even if there is no title #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
prnvshrn
commented
Dec 7, 2018
prnvshrn
commented
- I have added the functionality of deleting the resources which do not have a title / are not properly uploaded.
- A delete button appears besides such entries to perform the operation
jdamerow
requested changes
Dec 11, 2018
cookies/templates/resources.html
Outdated
|
|
||
| <script> | ||
| jQuery(document).ready(function($) { | ||
| $(".opendeleteResourceModal").click(function(e) { |
cookies/templates/resources.html
Outdated
| <h4 class="modal-title">Delete entry</h4> | ||
| </div> | ||
| <div class="modal-body"> | ||
| <p>Do you want to delete this invalid entry ? </p> |
|
|
||
|
|
||
| @login_required | ||
| def delete_resource(request, resource_id): |
jdamerow
reviewed
Dec 11, 2018
| def delete_resource(request, resource_id): | ||
| # Extra check to ensure that only resources which do not have primary id get deleted. | ||
| resource_container = ResourceContainer.objects.get(pk=resource_id) | ||
| if resource_container.primary_id is None and request.user.id == resource_container.created_by_id: |
There was a problem hiding this comment.
you need to check with the permissions here. other people can have access to a resource and can delete them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.