Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #289

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Prepare release #289

merged 3 commits into from
Dec 16, 2024

Conversation

jdamerow
Copy link
Member

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

... Put ticket description here and add link to ticket ...

Are there any other pull requests that this one depends on?

Anything else the reviewer needs to know?

... describe here ...

dependabot bot and others added 3 commits November 26, 2024 13:58
Bumps [org.springframework.security.oauth:spring-security-oauth2](https://github.com/SpringSource/spring-security-oauth) from 2.4.0.RELEASE to 2.4.2.RELEASE.
- [Commits](spring-attic/spring-security-oauth@2.4.0.RELEASE...2.4.2.RELEASE)

---
updated-dependencies:
- dependency-name: org.springframework.security.oauth:spring-security-oauth2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julia Damerow <[email protected]>
)

* [CITE-93] Async loading of items

* [CITE-93] Worked on creating JSON response

* Async loading backend completed

* in progress

* [CITE-93] git statys

* [CITE-93] trying to insert data into table

* [CITE-93] manipulating table data, collections, and all others using synced citations data

* [CITE-93] removed unnecessary code

* [CITE-93] removed unnecessary code

* [CITE-93] removed unnecessary code

* [CITE-93] rewriting citations table data with Json items data

* [CITE-93] in progress

* [CITE-93] in progress

* [CITE-93] table data is getting updated

* [CITE-93] date and url elements fixed

* [CITE-93] icon should appear before label

* [CITE-93] Rewrote collections list and others paers of the page

* citations icons and label data is being sent from backend, now they are appearing while rewriting the table

* [CITE-93] readded event listeners and href are working

* [CITE-93] added hrefs and other html elements

* [CITE-93] corrected semicolon after author names

* [CITE-93] fixed bug, that is collections count is not updating while rewriting collections list with synced data

* [CITE-93] rewrote group info html elements with synced data

* [CITE-93] fixed potential code break due to changes in html collection id

* [CITE-93] removed unused imports and indentation changes

* [CITE-93] correction in request mapping url value

* [CITE-93] removing items data from contoller backing items page. Adding that extra data to controller that handles polling requests

* [CITE-93] calling polling contoller on first load and removed items code from main controller and items.html page

* [CITE-93] Fixed search functionality which was broken when removing html code that creates citations table from modal data. Chnages made in SearchController. Returning json string instead of adding attributes to modal while serving search request from SearchContoller

* [CITE-93] Fixing pagination and columns on items.html which got affected by removing modal data. Also addressing other ajax calls that reloads items.html page, by executing jquery functions after receiving data

* [CITE-93] Fixed columnslist

* [CITE-93] Fixed search results when/while columns are added to citations table. Fixed columns checkmark.

* [CITE-93] Fixed pagination while searching

* [CITE-93] Fixed sub collection hrefs, Fixed collections list toggle functionality

* [CITE-93] addressed review comments

* [CITE-93] Removed unused imports

* [CITE-93] Added javadoc

* [CITE-93] Indentation changes

* [CITE-93] fixed typos

* [CITE-93] Indentation change

* [CITE-93] Indentation change

* [CITE-93] Trying to fix code factor issues

* [CITE-93] Trying to fix code factor issues

* [CITE-93] Resloved a bug where checkbox/Move items event listeners are not working after rewriting columns data.

* [CITE-93] Resolved null pointer exception on job list

* [CITE-93] Fixing the FetchItemsController

* [CITE-93] Fixed pagenation issue

* [CITE-93] Resolved some errors related to delete citation

* [CITE-93] Added spinner at the end of table

* [CITE-93] Resolving issue regarding loading spinner

* [CITE-93] Added files & details column to table

* [CITE-93] Resolved table-spinner timing issue

* [CITE-93] Resolved changing order during search issue

* [CITE-93] Removing unwanted changes

---------

Co-authored-by: Akhil <[email protected]>
Co-authored-by: Narmada Ravali Namburi <[email protected]>
* Trying to fix token expire in issue

* Revert spring oauth update

* Set token validity

* adding setter for access token validity

* Upgrading spring oauth again

since that wasn't the issue
@diging-jenkins
Copy link

Jenkins successfully deployed Citesphere to be reviewed!

@jdamerow jdamerow merged commit 488cdfd into master Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants