Story/geco 122 #23
Story/geco 122 #23
Conversation
…w the options on the UI in system config
…function in EditPropertiesContoller.java
…non managed Spring class
…stemHandler in the Tesseract Constructor
| @Autowired | ||
| private IKafkaRequestSender kafkaRequestSender; | ||
|
|
||
| @Autowired | ||
| private ISystemMessageHandler messageHandler; | ||
|
|
||
| @Autowired | ||
| private SystemMessageHandler msgHandler; |
| page.setOCRType(Properties.OCR_HOCR); | ||
| } else { | ||
| page.setOCRType(Properties.OCR_PLAINTEXT); | ||
| page.setLanguageType(defaultLang); |
There was a problem hiding this comment.
why do you not set the default language if ocr type is HOCR?
| try { | ||
| Process proc; | ||
| BufferedReader reader; | ||
| proc = Runtime.getRuntime().exec(command); |
cassiopeia/src/main/java/org/apache/tika/parser/ocr/TesseractOCRParser.java
Show resolved
Hide resolved
| output = output + line + " "; | ||
| } | ||
| proc.waitFor(); | ||
| reader.close(); |
There was a problem hiding this comment.
the reader always needs to be closed, even if an exception is thrown.
| reader = new BufferedReader(new InputStreamReader(proc.getInputStream())); | ||
| String line = ""; | ||
| while ((line = reader.readLine()) != null) { | ||
| output = output + line + " "; |
| lang_list = output.split(":"); | ||
|
|
||
| String[] languages; | ||
| languages = lang_list[1].split(" "); |
There was a problem hiding this comment.
why don't you read the the output into a list right away since it's one language per line, isn't it?
There was a problem hiding this comment.
no string manipulations necessary
|
there don't seem to be any changes |
…cassiopeia into story/GECO-122 Merged required for the new changes
| for (int i = 1; i < langs.size(); i++) { | ||
| langTypeMap.put(langs.get(i), langs.get(i)); | ||
| } | ||
| tessPars = null; |
| page.setOCRType(Properties.OCR_HOCR); | ||
| } else { | ||
| page.setOCRType(Properties.OCR_PLAINTEXT); | ||
| } | ||
|
|
||
| page.setLanguageType(defaultLang); |
There was a problem hiding this comment.
let's move that to line 76 to keep it together with the rest of the default language code
| * @param propertyManager | ||
| * @return String[] - the list of available languages | ||
| */ | ||
| public List<String> getTessLangs(IPropertiesManager propertyManager) { |
There was a problem hiding this comment.
let's not introduce a new dependency here, just use the TesseractOCRConfig class used in the other methods.
| sysMsgHandler.handleMessage("Error while getting Tesserract languages.", e, MessageType.ERROR); | ||
| } catch (InterruptedException e) { | ||
| sysMsgHandler.handleMessage("Error while getting Tesserract languages.", e, MessageType.ERROR); | ||
| } |
There was a problem hiding this comment.
this needs a finally block in which you close the reader
| String line = ""; | ||
| while ((line = reader.readLine()) != null) { | ||
| output.add(line); | ||
| } |
There was a problem hiding this comment.
you still need a comment here, explaining why you are doing what you're doing. and wasn't the first line, not a language?
There was a problem hiding this comment.
I will add the comments.
The first line is "List of available languages:(3)" and therefore it is not required.
…age,up the page by 4-5 lines.
…TessLangs() in TesseractOCRConfig class.
No description provided.