Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/GECO-140: Adding deletion endpoint to the V2 API #114

Open
wants to merge 31 commits into
base: story/GECO-139
Choose a base branch
from

Conversation

diya17
Copy link
Contributor

@diya17 diya17 commented Mar 16, 2023

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

(you can copy the ticket if it hasn't changed)

https://diging.atlassian.net/browse/GECO-140

Anything else the reviewer needs to know?

Depends on
#113
diging/giles-eco-requests#18
diging/giles-eco-nepomuk#30
#109

@diging-jenkins
Copy link

Can one of the admins verify this patch?

@diya17 diya17 requested a review from jdamerow March 16, 2023 18:46
return new ResponseEntity<String>(HttpStatus.NOT_FOUND);
}
deleteDocumentService.deleteDocument(document);
return new ResponseEntity<String>(HttpStatus.ACCEPTED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should return an ok status and a url to poll to get the status of the deletion process.

@jdamerow jdamerow closed this May 12, 2023
@diya17 diya17 reopened this Jun 1, 2023
@diya17 diya17 requested a review from jdamerow July 3, 2023 17:32
@diya17 diya17 closed this Jul 31, 2023
@diya17 diya17 reopened this Jul 31, 2023
@jdamerow
Copy link
Member

Resolve conflicts please

@jdamerow jdamerow closed this Apr 10, 2024
@diya17 diya17 reopened this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants