Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix happy to 1.20.1.1 #559

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Sep 20, 2024

happy 2.0.1 was released yesterday https://hackage.haskell.org/package/happy-2.0.1.

as indicated by these build failures https://github.com/digital-asset/ghc-lib/actions/runs/10950791602, ghc bootstrapping apparently demands happy <=happy-1.20.1.1

configure: error: Happy version 1.20 or earlier is required to compile GHC.

this PR adds the constraint happy < 2.0 to ghc-lib-gen.cabal which enables us to recover working CI pipelines.

the same constraint is also added to (generated) ghc-lib/ghc-lib-parser cabal files which fixes #557.

Copy link
Contributor

@samuel-williams-da samuel-williams-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shayne!

@samuel-williams-da samuel-williams-da merged commit ad20856 into digital-asset:master Sep 23, 2024
39 checks passed
@shayne-fletcher shayne-fletcher deleted the fix-happy branch September 23, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghc-lib-parser-9.10.1.20240511 no longer builds
2 participants