Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-provided test suite and assert @version correctly when specified (port of #179 to 0.5.x) #180

Open
wants to merge 9 commits into
base: 0.5.x
Choose a base branch
from

Conversation

aredridel
Copy link

This does not get CI working, as the tests (obviously) do not pass yet for this branch. However, it does make it possible to see real status in CI.
.

  • I published the json-ld.org test suite as an npm module. I'm happy to pass on the keys to that npm package for updates if that is a concern; Also happy to maintain that going forward, I don't anticipate a lot of work there, but won't be making it a priority for my work unless someone wants to poke me about it
  • I added code to conform to tp003 and tp006 tests, asserting that version is 1.1 if it is specified at all.

@davidlehn
Copy link
Member

@version support added in 0.5.x here:
f6a91c0

@gkellogg
Copy link
Collaborator

I think this PR is probably obsolete with the collective changes in https://github.com/digitalbazaar/jsonld.js/tree/0.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants