Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1853: Fix the style of dialogs in the app #1857

Conversation

seluianova
Copy link
Contributor

@seluianova seluianova commented Jan 9, 2025

Short description

Fix styling issues in the dialogs

Proposed changes

  • Add CustomAlertDialog widget and re-use it to unify the style of dialogs

Side effects

Couldn't find any

Testing

Check different dialogs in the app (I believe I checked every dialog I touched)

Resolved issues

Fixes: #1853
Fixes: #1846

And some other findings, like

image

Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on android and ios.
Nicely done 👍
Good refactoring, couldn't find any issues!

@seluianova seluianova merged commit 9fd8bcb into main Jan 17, 2025
2 checks passed
@seluianova seluianova deleted the 1853-renderflex-overflowed-error-in-the-card-verification-dialog branch January 17, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RenderFlex overflowed error in the card verification dialog Increase alert text font size
3 participants