Fix empty Zammad field in region form

digitalfabrik · Oct 4, 2024 · 10ba594 · 10ba594
1 parent 079fad8
commit 10ba594
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/integreat_cms/cms/forms/regions/region_form.py b/integreat_cms/cms/forms/regions/region_form.py
@@ -594,13 +594,14 @@ def clean_hix_enabled(self) -> bool:
             )
         return cleaned_hix_enabled
 
-    def clean_zammad_url(self) -> str:
+    def clean_zammad_url(self) -> str | None:
         """
         Validate the zammad_url field (see :ref:`overriding-modelform-clean-method`).
 
         :return: The validated field
         """
-        cleaned_zammad_url = self.cleaned_data["zammad_url"]
+        if not (cleaned_zammad_url := self.cleaned_data["zammad_url"]):
+            return None
         # Remove superfluous path parts
         cleaned_zammad_url = cleaned_zammad_url.split("/api/v1")[0]
         cleaned_zammad_url = cleaned_zammad_url.rstrip("/")

diff --git a/integreat_cms/release_notes/current/unreleased/3098.yml b/integreat_cms/release_notes/current/unreleased/3098.yml
@@ -0,0 +1,2 @@
+en: Fix bug when saving a Region without a Zammad URL
+de: Fehlerkorrektur beim Speichern einer Region ohne Zammad URL