Implement region condition data export #3079
Conversation
Speed is not great, unfortunately. An export using production data takes about 6 minutes
|
Code Climate has analyzed commit 56d8a2e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 72.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.6% (0.0% change). View more on Code Climate. |
Very hacky fix, but we are already using it at feedback_resource
| @permission_required("cms.view_region") | ||
| def export_region_conditions(request: HttpRequest, file_format: str) -> HttpResponse: | ||
| """ | ||
| Creates a data export summarizing the condition of all region |
There was a problem hiding this comment.
| Creates a data export summarizing the condition of all region | |
| Creates a data export summarizing the condition of all regions |
|
@david-venhoff Thank you for the PR, looks very good 😸 There is one question: shouldn't the feature only be available for Service Team (+ CMS)? it doesn't harm that App Team and Marketing Team can use this functionality, though it was so specified in the issue 🤔 |
|
Had a quick look and for the stock dev test data it takes 43 queries (6 regions). EDIT: I am no longer confident that we can significantly reduce this without major refactoring of the rest of our system to do less with python logic and more passing and building on querysets – which would also be an interest of mine, but not reasonable within the scope of this issue |
| #: cms/templates/region_condition/region_condition.html | ||
| msgid "This page is under construction" | ||
| msgstr "Diese Seite ist unter Konstruktion" |
There was a problem hiding this comment.
The least important of this PR, but I believe this is the proper phrase in German
| #: cms/templates/region_condition/region_condition.html | |
| msgid "This page is under construction" | |
| msgstr "Diese Seite ist unter Konstruktion" | |
| #: cms/templates/region_condition/region_condition.html | |
| msgid "This page is under construction" | |
| msgstr "Diese Seite ist noch im Bau" |
| It represents the to-be exported status of all regions. | ||
| """ | ||
|
|
||
| name = fields.Field(column_name=_("Region name"), attribute="name") |
There was a problem hiding this comment.
What do you think, does it make more sense to just say "Region" in this column?
| name = fields.Field(column_name=_("Region name"), attribute="name") | |
| name = fields.Field(column_name=_("Region"), attribute="name") |
| has_translation_package_been_booked = fields.Field( | ||
| column_name=_("Has translation package been booked"), |
There was a problem hiding this comment.
I think adding a question mark makes it slightly better at conveying the meaning
| has_translation_package_been_booked = fields.Field( | |
| column_name=_("Has translation package been booked"), | |
| has_translation_package_been_booked = fields.Field( | |
| column_name=_("Has translation package been booked?"), |
|
@PeterNerlich Thanks for the review :)
I share this sentiment, and I went on to exactly the same investigation as you 🥲 |
There was a problem hiding this comment.
Thank you very much! This looks quite good already. However I noticed a few things when reviewing this with our test data.
Number of missing or outdated translations: In our test data I have eight pages that have a missing or outdated translation, the CSV says seven. I have the same error in Augsburg where I had 25 outdated translations for not empty pages, the CSV only says 19. Maybe it's worth to have a look at this branch, where attempted at implementing something similar :)
The rest seemed to be accurate. I think however that thorough testing after merging would be a great benefit :)
Short description
Adds a new admin page with a button to download a region condition export.
The page itself is very minimal and will be improved with #3012.
Speed is not great, unfortunately. An export using production data takes about 6 minutes.
Proposed changes
Side effects
None
Resolved issues
Fixes: #3053
Pull Request Review Guidelines