go mod tidy and update Dockerfile go version #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llDrLove
reviewed
May 8, 2024
| @@ -1,36 +1,38 @@ | |||
| module github.com/digitalocean/do-operator | |||
|
|
|||
| go 1.21 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
Should this match the toolchain value ?
There was a problem hiding this comment.
nope, not necessarily; when we specify go 1.22 and run go mod tidy, this is what we get by default. this is how they are for many other repos with go 1.22 update (ex. CCM go.mod)
here are the two docs I have on go toolchain: https://go.dev/doc/toolchain (not as helpful as the other doc) and https://news.ycombinator.com/item?id=36455694 (the first answer). AFAIU the go directive is still like the minimum go toolchain version while the toolchain directive is used to specify the precise compiler version that should be used..?
timoreimann
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.