update dependencies #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-honeybadger
force-pushed
the
dkomsa/update-dependencies
branch
from
b610967 to
286c094
Compare
| @@ -12,94 +12,12 @@ rules: | |||
| verbs: | |||
| - create | |||
| - patch | |||
| - apiGroups: | |||
| - "" | |||
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
Not really removing. This is auto-generated by controller-gen, and, after it's been updated, the new version consolidated rbac permissions into fewer sections. I.e. in the new file https://github.com/digitalocean/do-operator/blob/976400bfda72e67b2174408058342d28b200bffd/config/rbac/role.yaml there's still create and patch on secrets, it's just bundled together with configmaps. Similar with database resources - they're just bundled into a single section with the same verbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates go and all dependencies