c-for-go: use digitalocean-labs fork #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Te current c-for-go project needs enhancement in order to accomodate generating bindings from the latest libvirt source. This situation can be addressed by using a private fork (at least, until any required changes can be merged upstream). This commit streamlines the build process for c-for-go to allow building a private version to the bin/ directory. This allows go-libvirt to operate without contaminating the GOPATH with a different version. This commit adds a 'replace' directive to go.mod in order to allow for the eventual usage of a custom version, but does not yet move utilize a different version (because the commit referenced in go.mod is unchanged). Because the 'go install' tool recently changed behavior to NOT update the go.mod file, this commit also adds a reference to c-for-go in a file using an unused build tag in order for it to persist, so that the 'replace' directive remains effective.
mpontillo
force-pushed
the
mpontillo/build-private-c-for-go
branch
from
c27484e to
bfbdb49
Compare
trapgate
reviewed
Feb 12, 2024
|
|
||
| - name: Install golint | ||
| run: go get -u golang.org/x/lint/golint | ||
| run: go install golang.org/x/lint/golint@latest |
There was a problem hiding this comment.
You could use golangci for this - it'd be a superset of golint, and there's a public action for it.
|
I should also mention that the c-for-go project has accepted patches from us in the past, though I haven't looked at the changes this time round so I don't know if this is something they're likely to object to. |
|
Now that our |
|
Superseded by #212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Te current c-for-go project needs enhancement in order to accomodate generating bindings from the latest libvirt source.
This situation can be addressed by using a private fork (at least, until any required changes can be merged upstream). This commit streamlines the build process for c-for-go to allow building a private version to the bin/ directory. This allows go-libvirt to operate without contaminating the GOPATH with a different version.
This commit adds a 'replace' directive to go.mod in order to allow for the eventual usage of a custom version, but does not yet move utilize a different version (because the commit referenced in go.mod is unchanged).
Because the 'go install' tool recently changed behavior to NOT update the go.mod file, this commit also adds a reference to c-for-go in libvirt.go in order for it to persist, so that the 'replace' directive remains effective.