Provide a custom retryablehttp.ErrorHandler for more consistent returns using retries. #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve a number of inconsistencies/issues when using
WithRetryAndBackoffs
. Currentlywhen a retry happens:err.Error()
returns the messy lookingGet "http://127.0.0.1:45035/foo": GET http://127.0.0.1:45035/foo giving up after 4 attempt(s)
*godo.Response
returned by the resource methods is nil if there is an error. That is not consistent with existing godo or net/http. If there is an HTTP response, even an errpr, it should be returned.This uses a custom
ErrorHandler
in order to provide errors that are consistent with a*godo.ErrorResponse
and a non-nil*godo.Response
while still providing insight.