Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBaaS engine Kafka #633

Merged

Conversation

dwilsondo
Copy link
Contributor

Adds Kafka as a DBaaS engine.

Extends the following methods to accept Kafka specific user settings:

  • GetUser
  • ListUsers
  • CreateUser

Adds Kafka Responses:

  • ResetUserAuth
  • ListOptions (see: GetDatabaseOptions)

Adds support for Topic management:

  • ListTopics
  • CreateTopic
  • GetTopic
  • UpdateTopic
  • DeleteTopic

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great, but I did have a few questions inline.

Also, from the API responses, it looks like there are some new additions to the DatabaseConnection object that are not included here. I'm seeing:

      "application_ports": {
        "certificate": 25071,
        "sasl": 25080
      }

databases.go Outdated Show resolved Hide resolved
databases.go Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants