Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOKS: add custom CIDR fields #732

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

gottwald
Copy link
Contributor

This exposes the new create requests fields that allow to set custom CIDRs for the cluster and service subnets.

This exposes the new create requests fields that allow to set custom
CIDRs for the cluster and service subnets.
@loosla
Copy link
Contributor

loosla commented Sep 25, 2024

Hey Ingo,
Thanks for the update 🎉
Could you please include new fields in tests as well 🙏

createRequest := &KubernetesClusterCreateRequest{

createRequest := &KubernetesClusterCreateRequest{

@gottwald
Copy link
Contributor Author

@loosla done PTAL again

Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@loosla loosla merged commit 40ea734 into digitalocean:main Sep 25, 2024
8 checks passed
@gottwald gottwald deleted the ig/doks-custom-cidr branch September 25, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants