Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce droplet autoscale godo methods #743

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

asaha2
Copy link
Contributor

@asaha2 asaha2 commented Oct 21, 2024

Droplet autoscaling is not publicly available yet, and is only available through closed invites.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, but I did have a few comments/questions in-line.

droplet_autoscaler.go Outdated Show resolved Hide resolved
droplet_autoscaler.go Outdated Show resolved Hide resolved
droplet_autoscaler_test.go Outdated Show resolved Hide resolved
@asaha2
Copy link
Contributor Author

asaha2 commented Oct 22, 2024

@andrewsomething 6ff10a3 should have the necessary adjustments.

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Thanks for the quick changes!

@andrewsomething andrewsomething merged commit 5b0efa1 into digitalocean:main Oct 22, 2024
8 checks passed
@asaha2 asaha2 deleted the asaha/AUTOSCALE-35 branch October 22, 2024 21:59
@asaha2 asaha2 mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants