Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Spaces Keys API #768

Merged
merged 4 commits into from
Jan 10, 2025
Merged

support Spaces Keys API #768

merged 4 commits into from
Jan 10, 2025

Conversation

lee-aaron
Copy link
Contributor

Adds support for the Spaces Keys API based on digitalocean/openapi#958

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did leave a few minor comments in-line mostly about naming.

spaces_keys.go Outdated Show resolved Hide resolved
spaces_keys.go Outdated Show resolved Hide resolved
spaces_keys.go Outdated Show resolved Hide resolved
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks for the changes!

@andrewsomething andrewsomething merged commit 4a45b95 into digitalocean:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants