Spaces: Add CORS Configuration Support #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaelhe
changed the title
andrewsomething
requested changes
Aug 21, 2023
digitalocean/spaces/resource_spaces_bucket_cors_configuration.go
Outdated
Show resolved
Hide resolved
digitalocean/spaces/resource_spaces_bucket_cors_configuration_test.go
Outdated
Show resolved
Hide resolved
danaelhe
commented
Aug 23, 2023
| @@ -62,6 +62,7 @@ func ResourceDigitalOceanBucket() *schema.Resource { | |||
| Type: schema.TypeList, | |||
| Optional: true, | |||
| Description: "A container holding a list of elements describing allowed methods for a specific origin.", | |||
| Deprecated: "Terraform will only perform drift detection if a configuration value is provided. Use the resource `digitalocean_spaces_bucket_cors_configuration` instead.", | |||
There was a problem hiding this comment.
Adding deprecation flag to encourage users to use digitalocean_spaces_bucket_cors_configuration. AWS deprecated this to add more flexibility with bucket creations:
hashicorp/terraform-provider-aws#4418
ooof, at first I was running the test in a way that gave me false positives. Thanks for double checking. |
andrewsomething
requested changes
Aug 28, 2023
digitalocean/spaces/resource_spaces_bucket_cors_configuration_test.go
Outdated
Show resolved
Hide resolved
digitalocean/spaces/resource_spaces_bucket_cors_configuration_test.go
Outdated
Show resolved
Hide resolved
digitalocean/spaces/resource_spaces_bucket_cors_configuration_test.go
Outdated
Show resolved
Hide resolved
digitalocean/spaces/resource_spaces_bucket_cors_configuration_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1015
Users can configure advance settings for CORS via the
digitalocean_spaces_bucket_cors_configurationresource.