Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary file read #458

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

miniBill
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Mar 23, 2024

👷 Deploy request for elm-pages-todos pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5a380c5

@miniBill miniBill marked this pull request as ready for review March 23, 2024 19:28
@miniBill miniBill changed the title [WIP] add suport for binary file read Add suport for binary file read Mar 23, 2024
@miniBill miniBill changed the title Add suport for binary file read Add support for binary file read Mar 30, 2024
@miniBill
Copy link
Contributor Author

Rebased

@miniBill
Copy link
Contributor Author

@dillonkearns how do you feel about this PR? Does it look like it could be merged or would you prefer to have a discussion around APIs, base64 and efficiency?

@miniBill miniBill force-pushed the binary-read branch 2 times, most recently from db96aaa to da00f8c Compare December 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants