Skip to content

Commit

Permalink
refactor: use digest instead of tag for raycluster image
Browse files Browse the repository at this point in the history
  • Loading branch information
dimakis committed Nov 8, 2023
1 parent 9380986 commit 080c5a4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/codeflare_sdk/cluster/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class ClusterConfiguration:
instascale: bool = False
mcad: bool = True
envs: dict = field(default_factory=dict)
image: str = "quay.io/project-codeflare/ray:latest-py39-cu118"
image: str = "quay.io/project-codeflare/ray@sha256:1ddf39c1bbb182bc9f9c477fa0003902506013f8721f7e203673f965156f5559"
local_interactive: bool = False
image_pull_secrets: list = field(default_factory=list)
dispatch_priority: str = None
Expand Down
5 changes: 4 additions & 1 deletion tests/unit_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,10 @@ def test_config_creation():
assert config.min_cpus == 3 and config.max_cpus == 4
assert config.min_memory == 5 and config.max_memory == 6
assert config.num_gpus == 7
assert config.image == "quay.io/project-codeflare/ray:latest-py39-cu118"
assert (
config.image
== "quay.io/project-codeflare/ray@sha256:1ddf39c1bbb182bc9f9c477fa0003902506013f8721f7e203673f965156f5559"
)
assert config.template == f"{parent}/src/codeflare_sdk/templates/base-template.yaml"
assert config.instascale
assert config.machine_types == ["cpu.small", "gpu.large"]
Expand Down

0 comments on commit 080c5a4

Please sign in to comment.