Improve file handling robustness #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UTF-8 encoding and add error handling. Handle invalid character (backslash) in the path. Attachment can be None, code now handles this case properly. filename can contain invalid characters and can be split into multiple parts using filename* parameters, code now handles this case properly. parent directory sometimes doesn't exist before trying to save the file, code now has proper directory creation handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I tried to process about 70,000 eml files and some errors occurred that I was able to fix for myself. I could not find any more errors with my files and wanted to share the code. Maybe it will help someone else.
Add UTF-8 encoding and add error handling.
Handle invalid character (backslash) in the path.
Attachment can be None, code now handles this case properly.
filename can contain invalid characters and can be split into multiple parts using filename* parameters, code now handles this case properly.
parent directory sometimes doesn't exist before trying to save the file, code now has proper directory creation handling.