Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor towards MathematicalSystems.jl #389

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor towards MathematicalSystems.jl #389

wants to merge 3 commits into from

Conversation

blegat
Copy link
Collaborator

@blegat blegat commented Nov 8, 2024

Goes a bit further compared to #388

@johnaoga
Copy link
Collaborator

johnaoga commented Nov 8, 2024

This is clearer!
I think that we also need to set down some rules that we use internally to name and write things and that will help to be consistent writing new code/algorithms. Ping @blegat @adrienbanse @JulienCalbert

@adrienbanse
Copy link
Collaborator

@johnaoga I cannot find lowercase for functions and uppercase for structures in JuliaFormatter.

@blegat Is there any other option? Otherwise let's just be strict in the reviews

@johnaoga
Copy link
Collaborator

johnaoga commented Nov 8, 2024

@adrienbanse yeah, that why we need to have some rule between us to complement what's missing in the formatter.

@blegat
Copy link
Collaborator Author

blegat commented Nov 8, 2024

I like to follow the JuMP style guide https://jump.dev/JuMP.jl/stable/developers/style/ 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants