Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds gzip support for press module #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jakeyr
Copy link

@jakeyr jakeyr commented Dec 14, 2012

  • add Gzip class for compression of strings and inputstreams
  • modify controller to use gzip when accept-encoding header requests it
  • add new gzipEnabled configuration setting to enable gzip (default off)

Jacob Rosenberg added 2 commits December 13, 2012 17:33
- add Gzip class for compression of strings and inputstreams
- modify controller to use gzip when accept-encoding header requests it
@dirkmc
Copy link
Owner

dirkmc commented Dec 14, 2012

Hey, thanks for taking the time to add Gzip support, and share it with the community, that's great.
I hadn't added it before because I felt that it was probably best handled by the web server, rather than the application server. I'm going to merge your pull request anyway because you've made it configurable.
Could you please add a note to the documentation, and add your name to the Thanks list at the bottom as well?
Thanks!
Dirk

@jakeyr
Copy link
Author

jakeyr commented Dec 14, 2012

Yes, agreed that in most cases doing a CPU-intensive job like compression is a better job for the web server or even the LB or reverse proxy, but given that your efforts to get the core to support this at the netty level have been met with lukewarm responses, i figured we could do it here.

this spot, imo, is a good place to add gzip because when combined with a CDN using your web server as origin and the press module, you have a simple instant cached/gziped/edge-served solution. i would not recommend anyone not serving press content via a CDN turn this on, given that it's happening on every request. i'll explain as much in the doc modifications you asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants