openExternalLink returns a { opened: boolean } result
#282
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamzaAtDiscord
force-pushed
the
hamzahutchinson/change-open-external-link-response
branch
from
b030381
to
2faa932
Compare
jkap
reviewed
Nov 15, 2024
Comment on lines
+109
to
+112
| export const OpenExternalLinkResponse = zod.object({ | ||
| opened: zod.boolean(), | ||
| }); | ||
|
|
There was a problem hiding this comment.
general question: how does this behave against a version of the client that doesn't send the opened flag across RPC? my gut is that since this isn't marked as optional and we're using .parse() it would error out, but I also don't know if we have error handling for that buried elsewhere (I'm assuming we do since otherwise I imagine this would have been a problem already).
matthova
reviewed
Nov 15, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@discord/embedded-app-sdk", | |||
| "version": "1.7.0", | |||
| "version": "1.7.1", | |||
There was a problem hiding this comment.
nit - we don't bump the package version in the PR, it happens automatically via the release please github action.
nit - I think this is a feature, not a patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the return type for
openExternalLink. With this change the result ofopenExternalLinkwill be an object containing a boolean valueopened.If
openedis true, then the link was opened by the userIf
openedis false, then the link was not opened by the userThe lifetime of the promise is also changed. Previously the promise completed after opening the "Leaving Discord" dialog, but with this change the promise completes after the user selects an action in the dialog (visit the site, or go back). If the dialog does not appear because the site visit is automatically approved, then the promise returns
{ opened: true }following the link opening.