Skip to content

Commit

Permalink
refactor ref/gestures
Browse files Browse the repository at this point in the history
remove preserveScrollMomentum + scrollBuffer + lockableScrollableContentOffsetY props

we're using `preserveScrollMomentum` in the media picker, but i'm removing it because i feel the behavior is actually detrimental to the UX, and to simplify the refactor to scrollEnabled in the next commit.

`lockableScrollableContentOffsetY` is removed since it won't be necessary after the scrollEnabled refactor

`scrollBuffer` was no longer used.

removed custom gesture/scroll handling hooks

after refactoring to use scrollEnabled, we can add other props to add custom behaviors if needed.

refactored scroll/pan gesture interaction based on software-mansion/react-native-gesture-handler#420 (comment)

and approach from rngh example

https://github.com/software-mansion/react-native-gesture-handler/blob/main/example/src/new_api/bottom_sheet/index.tsx#L87

scrollEnabled inspired by react-native-swipe-modal

https://github.com/birdwingo/react-native-swipe-modal
  • Loading branch information
yayvery committed Mar 18, 2024
1 parent 8093e96 commit 9fd7242
Show file tree
Hide file tree
Showing 30 changed files with 509 additions and 1,628 deletions.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 9fd7242

Please sign in to comment.